Use java 9 ALPN if available #3555
Conversation
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
okay to test |
|
This is related to #3401 in some ways, because it revamps how we handle Providers. |
| */ | ||
| static boolean isNettyJava9AlpnAvailable() { | ||
| try { | ||
| Class.forName("io.netty.handler.ssl.Java9SslEngine"); |
There was a problem hiding this comment.
We don't tend to do this sort of thing. We instead just upgrade to the netty that supports the feature we need.
| } | ||
| }); | ||
| getApplicationProtocol.invoke(engine); | ||
| } catch (Throwable t) { |
There was a problem hiding this comment.
Could we just catch Exception, or similar? I'd rather not catch every Error and throw it away, as it can hide legitimate problems.
* assume bundled Netty version supports JDK ALPN
|
okay to test |
dapengzhang0
added
the
kokoro:run
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
kokoro-team
removed
the
kokoro:run
|
CLA signed |
ejona86
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
|
Thank you! |
6 participants
Netty
4.1.16supports Java 9 ALPN, gRPC should take advantage of that to ease deployment (especially on platforms without tcnative and/or openssl).This PR determines whether Java 9 ALPN and Netty 4.1.16 is available and enables Netty Java 9 ALPN.